forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pose_instability_detector): add pose_instability_detector module #1542
Merged
wakabame
merged 14 commits into
beta/v0.3.19
from
feat/localization/pose_instability_detector/calculate_at_msg_callback
Sep 25, 2024
Merged
feat(pose_instability_detector): add pose_instability_detector module #1542
wakabame
merged 14 commits into
beta/v0.3.19
from
feat/localization/pose_instability_detector/calculate_at_msg_callback
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
…on target is ndt pose. Signed-off-by: TaikiYamada4 <[email protected]>
This feature is for odometry messages only now. Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Removed unnecessary logs Signed-off-by: TaikiYamada4 <[email protected]>
Please use nav_msgs/msg/Odometry type messages for pose_instability_detector. Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/config/pose_instability_detector.param.yaml
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
...nstability_detector/include/autoware/pose_instability_detector/pose_instability_detector.hpp
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/launch/pose_instability_detector.launch.xml
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/launch/pose_instability_detector.launch.xml
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/schema/pose_instability_detector.schema.json
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/schema/pose_instability_detector.schema.json
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/src/pose_instability_detector.cpp
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/test/test_message_helper_node.hpp
Outdated
Show resolved
Hide resolved
yn-mrse
reviewed
Sep 24, 2024
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Yuma Nihei <[email protected]>
yn-mrse
approved these changes
Sep 25, 2024
yn-mrse
reviewed
Sep 25, 2024
...nstability_detector/include/autoware/pose_instability_detector/pose_instability_detector.hpp
Outdated
Show resolved
Hide resolved
…nstability_detector/pose_instability_detector.hpp Co-authored-by: Yuma Nihei <[email protected]>
…etector/calculate_at_msg_callback
Quality Gate passedIssues Measures |
@yn-mrse |
yn-mrse
approved these changes
Sep 25, 2024
wakabame
deleted the
feat/localization/pose_instability_detector/calculate_at_msg_callback
branch
September 25, 2024 03:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
本PRでは自己位置推定はずれ検知を行う
pose_instability_detector
を導入しますpose_instability_detector
は以下の機能を提供します;Related links
Parent Issue: https://tier4.atlassian.net/browse/AEAP-1118
How was this PR tested?
pose_instability_detector.launch.xml
を用いた pose_instability_detector の単体起動を行いました機能性能確認
性能評価資料 にて示されている性能値と上記LSim結果としての推定ズレ量がおよそ一致することを確認しました。
性能評価資料にて利用したROSBAGを再生し、自己位置推定のずれ量が最大値となった瞬間のずれ量を比較しています。
※以下検証用のグラフは横軸の時間の絶対値が毎計測ごとにずれてしまう。入力の波形をもとに比較時刻を合わせます
入力データ(比較参照用)
性能評価資料では150 sec 近辺で自己位置推定ずれが最大となっていたが、今回試験では入力波形から 210 sec 近辺 が該当することがわかります
位置推定ずれ比較データ
リグレッション確認
妥当性確認
検証
output_x_y_yaw_only=true
の場合output_x_y_yaw_only=false
の場合ログ出力が仕様通りに行われていることを、Lsim 起動直後の INFO, WARN ログから確認しました
Notes for reviewers
検証項目詳細は https://tier4.atlassian.net/wiki/spaces/EP1/pages/3328901197 に記載しています
この機能はOSSにある pose_instability_detector 実装をベースに下記の差分が含まれます
heading_velocity_maximum
のデフォルト値はOSS版の16.667 [m/s]
から2.778 [m/s] = 10 [km/h]
に値を変更している(参照)Interface changes
None.
Effects on system behavior
None.